BUG: can_hold_element size checks on ints/floats #45273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 8, 2022
•
jbrockmendel
commented
- closes Column dtype change on write of improper value #26049
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
reviewed
Jan 8, 2022
| df = DataFrame([1, 2, 3, 4], columns=["col1"], dtype="uint8") | ||
| df.loc[2, "col1"] = 300 # value that can't be held in uint8 | ||
|
|
||
| # TODO: would be better to get uint16? |
There was a problem hiding this comment.
no i think this is fine, fine-grain upcasting is nice but we don't do it generally
There was a problem hiding this comment.
The answer is going to end up being "yes" as a side-effect of other upcoming bugfixes.
|
prob needs a whatsnew |
mroeschke
reviewed
Jan 9, 2022
| @@ -1852,16 +1852,23 @@ def np_can_hold_element(dtype: np.dtype, element: Any) -> Any: | |||
| tipo = maybe_infer_dtype_type(element) | |||
|
|
|||
| if dtype.kind in ["i", "u"]: | |||
| info = np.iinfo(dtype) | |||
There was a problem hiding this comment.
Nit: Not needed until after elif is_integer(element) or (is_float(element) and element.is_integer()):?
There was a problem hiding this comment.
good catch. will fix in an upcoming CLN branch (since getting the CI to green is a PITA these days)
mroeschke
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.