TYP: Add types for excel writer classes #45246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
approved these changes
Jan 7, 2022
jbrockmendel
reviewed
Jan 7, 2022
pandas/io/excel/_odswriter.py
Outdated
| @@ -8,7 +8,7 @@ | |||
| ) | |||
|
|
|||
| import pandas._libs.json as json | |||
| from pandas._typing import StorageOptions | |||
| from pandas._typing import StorageOptions, FilePath, WriteExcelBuffer | |||
There was a problem hiding this comment.
Had some issues with pre commit yesterday, will fix
jbrockmendel
reviewed
Jan 7, 2022
pandas/io/excel/_openpyxl.py
Outdated
| @@ -453,6 +459,8 @@ def write_cells( | |||
| self.sheets[sheet_name] = wks | |||
|
|
|||
| if validate_freeze_panes(freeze_panes): | |||
| # for mypy | |||
| assert freeze_panes is not None | |||
There was a problem hiding this comment.
not sure if its been discussed, but i think we should move away from the assert-for-mypy pattern, since with cast/ignore mypy will alert us when it is no longer necessary
jreback
added
IO Excel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.