Skip to content

REF: consolidate _validate_fill_logic in np_can_hold_element #45216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2022
Merged

REF: consolidate _validate_fill_logic in np_can_hold_element #45216

merged 1 commit into from
Jan 8, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Leaves us with no methods directly implemented in Int64Index/UInt64Index.

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Refactor Internal refactoring of code labels Jan 8, 2022
@jreback jreback added this to the 1.5 milestone Jan 8, 2022
@jreback jreback merged commit 3977d73 into pandas-dev:master Jan 8, 2022
@jbrockmendel jbrockmendel deleted the ref-index-validate_fill_value branch January 8, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions Refactor Internal refactoring of code
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback