Skip to content

DOC: fix doctests for depr closed arg #45203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Jan 5, 2022

closed is deprecated for inclusive, and this fixes the docstring warning.

should be backported 1.4.0

@attack68 attack68 requested a review from mroeschke January 8, 2022 09:00
@jreback jreback added this to the 1.4 milestone Jan 8, 2022
@jreback jreback added Docs Testing pandas testing functions or related to the test suite labels Jan 8, 2022
@jreback jreback merged commit 8e70bf1 into pandas-dev:master Jan 8, 2022
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

@meeseeksdev backport 1.4.x

@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

thanks @attack68

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 8, 2022

Something went wrong ... Please have a look at my logs.

@attack68 attack68 deleted the docstring_tests branch January 8, 2022 16:17
jreback pushed a commit that referenced this pull request Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants