Skip to content

allow multiple series argument calling in ufunc #45171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

miettal
Copy link

@miettal miettal commented Jan 3, 2022

@pep8speaks
Copy link

pep8speaks commented Jan 3, 2022

Hello @miettal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-03 08:46:43 UTC

@jbrockmendel
Copy link
Member

can you add a test for the bug(s) this fixes

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Bug ufuncs __array_ufunc__ and __array_function__ and removed Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 3, 2022
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep pls always add a test. also if this does fix things pls add a whatsnew note in bug fixes 1.4, reshape section is fine

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Feb 12, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but appears this PR is stale and broke some tests. If you'd like to continue please merge master, include a unit test, and verify the fix locally with the entire test suite, and we can reopen.

@mroeschke mroeschke closed this Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Stale ufuncs __array_ufunc__ and __array_function__
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: array ufuncs with more than 2 inputs fails with 2 or more pd.Series and scalar arguments
5 participants