Skip to content

TST: Clean pg8000 test #45164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2022
Merged

TST: Clean pg8000 test #45164

merged 2 commits into from
Jan 3, 2022

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

Added a precommit check to ensure we don't add this dependency such that the test doesn't run

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Jan 2, 2022
@mroeschke mroeschke added this to the 1.4 milestone Jan 2, 2022
@@ -175,3 +175,9 @@ repos:
entry: python scripts/pandas_errors_documented.py
language: python
files: ^pandas/errors/__init__.py$
- id: pg8000-not-installed-CI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to prevent someone adding pg8000 in the ci/deps in the future which would prevent this test from running.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i c ok sure

@jreback jreback merged commit 74209d2 into pandas-dev:master Jan 3, 2022
@mroeschke mroeschke deleted the tst/pg8000 branch January 3, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants