Skip to content

BUG: fix GH45032 iloc(axis=1).__setitem__ axis argument #45150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 3, 2022

Conversation

ellequelle
Copy link
Contributor

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

@ellequelle ellequelle requested a review from phofl January 1, 2022 02:18
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit is failing, otherwise lgtm

@ellequelle ellequelle requested a review from phofl January 3, 2022 16:14
@jreback jreback added this to the 1.4 milestone Jan 3, 2022
@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Jan 3, 2022
@jreback jreback merged commit db54c28 into pandas-dev:master Jan 3, 2022
@jreback
Copy link
Contributor

jreback commented Jan 3, 2022

thanks @ellequelle very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: iloc(axis=1).__setitem__ ignores axis
3 participants