Skip to content

TYP: type read_xml and deprecate passing positional arguments #45133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 4, 2022
Merged

TYP: type read_xml and deprecate passing positional arguments #45133

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
baa3ab2
TYP: Type read_xml and adjust type hints
phofl Dec 30, 2021
ab8f1c6
Fix typing issues
phofl Dec 30, 2021
9ff4878
Deprecate positional
phofl Dec 30, 2021
6998251
Adjust comment
phofl Dec 30, 2021
0b85c7d
Fix test
phofl Dec 30, 2021
3accd12
Add test
phofl Dec 30, 2021
1da9569
Add test and adjust type hint
phofl Dec 31, 2021
a2348a2
Merge remote-tracking branch 'upstream/master' into typ_xml
phofl Jan 1, 2022
ba355ba
Adjust dep test
phofl Jan 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pandas/tests/io/xml/test_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,19 @@ def test_read_xml_passing_as_positional_deprecated(datapath):
)


@td.skip_if_no("lxml")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test for None encoding. Can this new test be moved few lines earlier under previous ENCODING section (lines ~700-730). I wonder if we should also test for etree with None expecting success with tm.assert_frame_equal. etree tends to be more active in API so may change defaults with future versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added and moved

def test_wrong_encoding_for_lxml():
# GH#45133
data = """<data>
<row>
<a>c</a>
</row>
</data>
"""
with pytest.raises(TypeError, match="encoding None"):
read_xml(StringIO(data), parser="lxml", encoding=None)


@td.skip_if_no("lxml")
def test_stylesheet_file_like(datapath, mode):
kml = datapath("io", "data", "xml", "cta_rail_lines.kml")
Expand Down