Skip to content

Typ excel writer _base #45111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 30, 2021
Merged

Typ excel writer _base #45111

merged 11 commits into from
Dec 30, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 29, 2021

  • Ensure all linting tests pass, see here for how to run them

If this is ok, I will type the other classes too

@phofl phofl added the Typing type annotations, mypy/pyright type checking label Dec 29, 2021
twoertwein
twoertwein reviewed Dec 29, 2021
View reviewed changes
@twoertwein twoertwein mentioned this pull request Dec 30, 2021
Closed
twoertwein
twoertwein approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @phofl

If the overload+typevar issue is an issue in pyright, it will probably be fixed quickly. I would suggest merging this PR and then later bumping pyright with the shorter overload+typevar approach. This way, this PR might just make it into 1.4.

@twoertwein
Copy link
Member

@phofl The issue is already fixed in the just released pyright 1.1.202 :)

Feel free to remove the "Remove typevar" commit and bump the version of pyright here and here.

@jreback jreback added this to the 1.4 milestone Dec 30, 2021
@jreback
Copy link
Contributor

jreback commented Dec 30, 2021

@phofl ping when ready as @twoertwein ok here

@phofl
Copy link
Member Author

phofl commented Dec 30, 2021

Reverted the commit, let's see if it works

@twoertwein
Copy link
Member

Reverted the commit, let's see if it works

You also need to bump the pyright version (pyright is pinned).

@phofl
Copy link
Member Author

phofl commented Dec 30, 2021 •
edited
Loading

Ah, thx. Should have expected that

Edit: And missed your comment above

@phofl
Copy link
Member Author

phofl commented Dec 30, 2021

Looks good now, cc @jreback

@jreback jreback merged commit 9512393 into pandas-dev:master Dec 30, 2021
@jreback
Copy link
Contributor

jreback commented Dec 30, 2021

thanks @phofl

@phofl phofl deleted the typ_excel_writer branch January 28, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @twoertwein @jreback