Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: Ensure all minimum optional dependencies are tested #45103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Ensure all minimum optional dependencies are tested #45103
Changes from all commits
5f4e4aa
de605c5
c6e6e38
298a181
598ba83
89f398a
81fb362
89bdf9a
0295f69
af4262a
d7b796c
426233f
fe25d32
f703d55
ad80418
b4932c1
99e867d
0bc5d8c
a2c7323
f9ad348
c3fb633
2d2ce98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
@pytest.importorskip
here with minversion?(pretty sure the issue here is with fsspec's min version only, but not sure).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
@pytest.importorskip
I think I would have to specify the min version + 1 to guarantee skipping the min version. I think the +1 aspect isn't as simple as adding +1 to whatever comes out of__version__