Skip to content

CI: Split CI workflow into code checks, docbuild & web, and arraymanager #45097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 29, 2021

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Dec 28, 2021

ci.yml split into:

  • arraymanager.yml
  • code-checks.yml (includes pre-commit.yml now)
  • docbuild-and-upload.yml

@mroeschke mroeschke changed the title CI: Split CI workflow into code checks, docbuild & web, and arraymanager WIP: CI: Split CI workflow into code checks, docbuild & web, and arraymanager Dec 28, 2021
@mroeschke mroeschke marked this pull request as draft December 28, 2021 20:05
@jbrockmendel
Copy link
Member

Does this mean that if one fails we can re-run just that one?

@mroeschke
Copy link
Member Author

Does this mean that if one fails we can re-run just that one?

Yes where "one" is the entire workflow.

e.g. If the arraymanager tests fail, the docbuld or code checks won't be re-run
e.g. If one code check fails, all the code checks still need to be rereun actions/runner#432

@lithomas1
Copy link
Member

I think it might be worth waiting for github/roadmap#271. Of course we could also merge this now and revert when that is implemented.

@mroeschke mroeschke changed the title WIP: CI: Split CI workflow into code checks, docbuild & web, and arraymanager CI: Split CI workflow into code checks, docbuild & web, and arraymanager Dec 28, 2021
@mroeschke
Copy link
Member Author

mroeschke commented Dec 28, 2021

I think it might be worth waiting for github/roadmap#271. Of course we could also merge this now and revert when that is implemented.

github/roadmap#271 would make this a lot nicer (as well as our other workflows).

I have slight preference just splitting now to make re-running things more focused in the short term. Additionally I think the splitting here has a better separation of concerns IMO.

@mroeschke mroeschke marked this pull request as ready for review December 29, 2021 03:45
@mroeschke mroeschke added this to the 1.4 milestone Dec 29, 2021
@jreback jreback added the CI Continuous Integration label Dec 29, 2021
@jreback jreback merged commit fd5a8f4 into pandas-dev:master Dec 29, 2021
@jreback
Copy link
Contributor

jreback commented Dec 29, 2021

thanks @mroeschke seems ok to do now

@mroeschke mroeschke deleted the ci/ci_workflow_split branch January 7, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Split .github\workflows\ci.yml into separate workflows
4 participants