TST: More pytest idioms in tests/generic #45086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Dec 28, 2021
mroeschke
commented
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
mroeschke
added
the
Testing
jreback
requested changes
Dec 28, 2021
pandas/tests/generic/test_generic.py
Outdated
| else: | ||
| arr = np.empty(shape, dtype=dtype) | ||
| arr.fill(value) | ||
| def check_metadata(x, y=None): |
There was a problem hiding this comment.
can you move this to _testing? and call it assert_metadata or similar (doc-string & typing if you can)
jreback
approved these changes
Dec 28, 2021
| @@ -1470,3 +1470,15 @@ def assert_indexing_slices_equivalent(ser: Series, l_slc: slice, i_slc: slice): | |||
| if not ser.index.is_integer(): | |||
| # For integer indices, .loc and plain getitem are position-based. | |||
| assert_series_equal(ser[l_slc], expected) | |||
|
|
|||
|
|
|||
| def assert_metadata_equivalent(left, right): | |||
There was a problem hiding this comment.
ideally type these (followup ok)
There was a problem hiding this comment.
these have to be Series/DataFrame?
There was a problem hiding this comment.
also see if you can grep if we have any more _metadata checkers
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.