BUG+DEPR: Timestamp.fromtimestamp tz arg #45083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Dec 28, 2021
jbrockmendel
commented
- closes pd.Timestamp.utcfromtimestamp should return tzaware #22451
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
approved these changes
Dec 28, 2021
jreback
approved these changes
Dec 28, 2021
| return cls(datetime.utcfromtimestamp(ts)) | ||
|
|
||
| @classmethod | ||
| def fromtimestamp(cls, ts): | ||
| def fromtimestamp(cls, ts, tz=None): |
There was a problem hiding this comment.
type generally if possible (followup ok)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.