DEPR/ENH: support axis=None in min/max #45072
Conversation
jreback
added
Algos
|
what is the status of the other functions here? (e.g. sum, mean etc) do these need to do the same? |
the idea is to do the same for all of them, but it was less obvious how to implement it for the others. i guess if we're just doing the deprecation now, can deprecate them all at once. |
|
kk yeah would want this for 1.4 but for all if possible (separate PRs are ok or all at once) |
i'll try locally adding the deprecation for all of them and see if it Breaks The World. if not, will just add to this PR. |
| def max(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs): | ||
| def max( | ||
| self, | ||
| axis: int | None | lib.NoDefault = lib.no_default, |
There was a problem hiding this comment.
@simonjayhawkins is this going to render in the docs in a way we don't want?
(similar question bugs me in a WIP branch that changes the default from method="pad" in .replace)
Deprecate the current axis=None behavior so we can change it in 2.0 xref #21597