Skip to content

BUG: dropna changing index when nothing is dropped #45027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 23, 2021

# With nan as last element
# before
# 1.63 ms ± 113 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

# after
# 1.68 ms ± 91.5 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)


# without nan
# before
# 1.6 ms ± 68.5 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

# after
# 714 µs ± 63.3 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

@phofl phofl added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Dec 23, 2021
@jreback jreback added this to the 1.4 milestone Dec 23, 2021
@jreback jreback merged commit a3f3762 into pandas-dev:master Dec 23, 2021
@jreback
Copy link
Contributor

jreback commented Dec 23, 2021

ty!

@phofl phofl deleted the 41965 branch December 23, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: dropna('rows') changes index type even when no row was dropped
2 participants