TYP: type excel util module #45014
Merged
TYP: type excel util module #45014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Dec 22, 2021
phofl
commented
- Ensure all linting tests pass, see here for how to run them
twoertwein
reviewed
Dec 22, 2021
twoertwein
reviewed
Dec 22, 2021
twoertwein
reviewed
Dec 22, 2021
twoertwein
reviewed
Dec 22, 2021
twoertwein
requested changes
Dec 22, 2021
twoertwein
approved these changes
Dec 22, 2021
|
one more rebase pls |
|
Done |
jreback
approved these changes
Dec 28, 2021
|
|
||
|
|
||
| def maybe_convert_usecols( | ||
| usecols: str | list[int] | list[str] | usecols_func | None, |
There was a problem hiding this comment.
prob can share this with the parsers (followon, maybe put in _typing.py)?
There was a problem hiding this comment.
The configs there are a bit different unfortunately. Don't think we can share efficiently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.