Skip to content

REF: dont pass downcast=False to fillna from pytables #45010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2021
Merged

REF: dont pass downcast=False to fillna from pytables #45010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions pandas/io/pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3945,7 +3945,7 @@ def _create_axes(
new_name = name or f"values_block_{i}"
data_converted = _maybe_convert_for_string_atom(
new_name,
blk,
blk.values,
existing_col=existing_col,
min_itemsize=min_itemsize,
nan_rep=nan_rep,
Expand Down Expand Up @@ -4928,19 +4928,20 @@ def _unconvert_index(data, kind: str, encoding: str, errors: str) -> np.ndarray

def _maybe_convert_for_string_atom(
name: str,
block: Block,
bvalues: ArrayLike,
existing_col,
min_itemsize,
nan_rep,
encoding,
errors,
columns: list[str],
):
bvalues = block.values

if bvalues.dtype != object:
return bvalues

bvalues = cast(np.ndarray, bvalues)

dtype_name = bvalues.dtype.name
inferred_type = lib.infer_dtype(bvalues, skipna=False)

Expand All @@ -4956,13 +4957,9 @@ def _maybe_convert_for_string_atom(
elif not (inferred_type == "string" or dtype_name == "object"):
return bvalues

blocks: list[Block] = block.fillna(nan_rep, downcast=False)
# Note: because block is always object dtype, fillna goes
# through a path such that the result is always a 1-element list
assert len(blocks) == 1
block = blocks[0]

data = block.values
mask = isna(bvalues)
data = bvalues.copy()
data[mask] = nan_rep

# see if we have a valid string type
inferred_type = lib.infer_dtype(data, skipna=False)
Expand All @@ -4974,7 +4971,7 @@ def _maybe_convert_for_string_atom(
# expected behaviour:
# search block for a non-string object column by column
for i in range(data.shape[0]):
col = block.iget(i)
col = data[i]
inferred_type = lib.infer_dtype(col, skipna=False)
if inferred_type != "string":
error_column_label = columns[i] if len(columns) > i else f"No.{i}"
Expand All @@ -4986,11 +4983,7 @@ def _maybe_convert_for_string_atom(

# itemsize is the maximum length of a string (along any dimension)

# error: Argument 1 to "_convert_string_array" has incompatible type "Union[ndarray,
# ExtensionArray]"; expected "ndarray"
data_converted = _convert_string_array(
data, encoding, errors # type: ignore[arg-type]
).reshape(data.shape)
data_converted = _convert_string_array(data, encoding, errors).reshape(data.shape)
itemsize = data_converted.itemsize

# specified min_itemsize?
Expand Down