Skip to content

CI: Pin setuptools for sdist too #45000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2021
Merged

CI: Pin setuptools for sdist too #45000

merged 3 commits into from
Dec 21, 2021
+4 −1

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 21, 2021

Don't understand why this was green before

MarcoGorelli
MarcoGorelli approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback jreback added the CI Continuous Integration label Dec 21, 2021
@jreback jreback added this to the 1.4 milestone Dec 21, 2021
@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

hmm i am not sure that worked

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

Nope, this got reinstalled by the setup-miniconda step

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

This works now

@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

excellent! merge on green

@jreback jreback merged commit d64df84 into pandas-dev:master Dec 21, 2021
@jreback
Copy link
Contributor

jreback commented Dec 21, 2021

thanks @phofl

@phofl phofl deleted the pin_setuptools_sdist branch December 21, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @jreback @MarcoGorelli