-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WIP: CI: Pameterize locale tests specifically for Linux #44972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What are the motivations which have led to considering to remove the locale-specific builds? The reason I ask is because I see two different reasons to test against multiple locales:
The first category will probably benefit from this PR, as testing multiple locales becomes much faster and thus can be performed more frequently and efficiently. However, the second category will effectively lose coverage. Specifically, I personally run on the locale On another note, just to double-check: The |
Currently pandas only tests a European locale This PR ensures we are testing these locales (also with After this PR it would be easier in theory to tests more locales like |
26cb294
to
24b8e38
Compare
Looking to eventually eliminate the local-specific builds by parametrizing in specific tests