Skip to content

Bug: to_csv coercing datetime columns to same format #44964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 22, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 18, 2021

@phofl phofl added the IO CSV read_csv, to_csv label Dec 18, 2021
result = values._format_native_types(na_rep=na_rep, **kwargs)
result = result.astype(object, copy=False)
return result
# GH#21734 Process every column separate, they migh have different formats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate -> separately, migh-> might

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, fixed

@jreback jreback added this to the 1.4 milestone Dec 19, 2021
@jreback
Copy link
Contributor

jreback commented Dec 19, 2021

@phofl the web & docs build failed but hard to tell why, can you rebase

@phofl
Copy link
Member Author

phofl commented Dec 21, 2021

The web and docs failure was unrelated. An inventory was not available. greenish

@jreback jreback merged commit 7658a6a into pandas-dev:master Dec 22, 2021
@phofl phofl deleted the 21734 branch December 22, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datetimes are inconsistently truncated in to_csv
3 participants