Test added to check if MultiIndex is unique #44953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sukriti1
commented
Dec 18, 2021
•
sukriti1
commented
- closes BUG: Concat returns inconsistent MultiIndex #44786
- 1 tests added / passed
- Ensure all linting tests pass, see here for how to run them
- New test added to check if MultiIndex is unique
phofl
reviewed
Dec 18, 2021
sukriti1
force-pushed
the
multiindexTest
branch
from
4dfc240 to
07d896f
Compare
phofl
reviewed
Dec 18, 2021
jreback
requested changes
Dec 23, 2021
| # GH#44786 | ||
| df = DataFrame({"col": ["a", "b", "c"]}, index=["1", "2", "2"]) | ||
| result = concat([df], keys=["X"]) | ||
| assert not result.index.is_unique |
There was a problem hiding this comment.
can you make an expected by hand and use tm.assert_frame_equal
There was a problem hiding this comment.
Thank you for the feedback @jreback ! I just added an expected index. Now, I am checking if expected index is equal to the result index in tm.assert_frame_equal.
|
closing in favor of #45822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.