Skip to content

TST: Add test to Series.str.strip() #44912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

minnaau
Copy link

@minnaau minnaau commented Dec 15, 2021

@pep8speaks
Copy link

Hello @minnaau! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 111:1: E302 expected 2 blank lines, found 1
Line 126:1: W293 blank line contains whitespace
Line 131:1: W293 blank line contains whitespace
Line 136:1: W293 blank line contains whitespace
Line 141:1: W293 blank line contains whitespace
Line 146:1: W293 blank line contains whitespace

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to do?

This should remove only whitespaces at the beginning or end

@simonjayhawkins
Copy link
Member

Thanks @minnaau for the PR.

IIRC we have plenty of tests for the string methods on mixed object Series.

In the issue there is a suggestion that the docs could be updated to clarify the behavior.

So closing this PR as there is another PR open #44885 that is updating the docs and IMO we don't really need any additional tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.str.strip() removes numeric and bool values instead of only string whitespace
4 participants