Bug in concat casting all na levels to float #44902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Dec 15, 2021
phofl
commented
- closes BUG: Using pd.concat(axis="columns") on differently sized MultiIndexed DataFrames with a datetime index level containing exclusively NaT values causes the level in the returned DataFrame to be a float instead of a datetime #44900
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
phofl
added
Reshaping
pandas/core/arrays/categorical.py
Outdated
| @@ -422,7 +422,14 @@ def __init__( | |||
| # We remove null values here, then below will re-insert | |||
| # them, grep "full_codes" | |||
| arr_list = [values[idx] for idx in np.where(~null_mask)[0]] | |||
| arr = sanitize_array(arr_list, None) | |||
|
|
|||
| # Do not cast to float if we have only missing values | |||
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.