BUG: read_csv converting nans to 1 when casting bools to float #44901
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
IO CSV
jreback
reviewed
Dec 16, 2021
|
cc @gfyoung if any comments |
|
Sorry about dropping out on this, got swamped by work. Thanks for bringing it forward @phofl. |
gfyoung
approved these changes
Dec 17, 2021
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly based on #42944, but would like to get this into 1.4
cc @joelgibson if you would like to continue your initial pr
The xfail pyarrow case is not really related to the pyarrow engine, but to df.astype("bool") casting NaN to False