Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPR: non-keyword arguments in any #44896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: non-keyword arguments in any #44896
Changes from 27 commits
59bd617
389cb03
076efc0
7f643d6
d6df993
d2653da
0f15b62
831481c
284efd3
e002897
912b040
b229a3b
0c3ebd7
799e12b
3441523
cdb96f7
49a1b0b
76003ed
787616d
0375347
5573d34
a13ee6f
6e5b3ac
63ae9c1
1010e1e
424b213
8007cf1
a361637
ea19d40
2678298
96de045
86ad6ba
7dec331
b4b3a1f
11917aa
35c71b6
0e6d5eb
025c493
59ac830
d9d14e9
15bbc86
a8dd741
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to 1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the stacklevel from args in decorator (default value of 2) also works here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not correct to evaluate this at compile time. what should happen is that the deprecater can call
find_stack_level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback I don't understand what you mean, how should this be?
Just setting
stacklevel=find_stack_level()
doesn't work becauseany
is inside_add_numeric_operations
and is set viasetattr(cls, "any", any)
pandas/pandas/core/generic.py
Lines 10928 to 10948 in 073b353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean this needs to be handled in the decorator itself not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done in the decorator in other places though
pandas/pandas/io/parsers/readers.py
Lines 831 to 833 in e1b95fa
I've made an issue to handle this in the decorator itself #46687 , is it OK to keep that separate from this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i c, yeah we out to fix this but ok for here