Skip to content

CI: Fix PyPy CI #44887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Dec 17, 2021
Merged

CI: Fix PyPy CI #44887

merged 27 commits into from
Dec 17, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Dec 14, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

PyPy was not being pulled correctly. Its fixed now and have confirmed.

@lithomas1 lithomas1 marked this pull request as ready for review December 16, 2021 02:23
@lithomas1 lithomas1 added CI Continuous Integration PyPy labels Dec 16, 2021
@lithomas1 lithomas1 added this to the 1.4 milestone Dec 16, 2021
@lithomas1
Copy link
Member Author

@github-actions pre-commit.

@lithomas1 lithomas1 requested a review from jreback December 16, 2021 03:56
@jreback
Copy link
Contributor

jreback commented Dec 16, 2021

@lithomas1 can you merge master one more time (as i merged the pypy3 affecting PR :-<>)

@lithomas1 lithomas1 changed the title CI: Add missing pypy specifier to pypy build CI: Fix PyPy CI Dec 16, 2021
@lithomas1 lithomas1 marked this pull request as draft December 17, 2021 00:14
@lithomas1 lithomas1 marked this pull request as ready for review December 17, 2021 03:42
@lithomas1
Copy link
Member Author

@jreback. This is ready now.
There are a couple gotchas, though:

  • Cython 0.29.26 doesn't compile correctly for PyPy.
  • Coverage is disabled because it slows down everything a lot.
  • The CSV reader crashes are gone, but we're crashing a lot elsewhere, and that slows everything down when the crashed workers need to be restarted. So, I set the CI to not restart workers. Some tests may be missed, but otherwise we can't get through the test suite.

I'll open an issue as a follow up.

@jreback
Copy link
Contributor

jreback commented Dec 17, 2021

https://github.com/pandas-dev/pandas/runs/4562612265?check_suite_focus=true

i think this is actually failing (but the check is not)

@jreback
Copy link
Contributor

jreback commented Dec 17, 2021

@jreback. This is ready now. There are a couple gotchas, though:

  • Cython 0.29.26 doesn't compile correctly for PyPy.
  • Coverage is disabled because it slows down everything a lot.
  • The CSV reader crashes are gone, but we're crashing a lot elsewhere, and that slows everything down when the crashed workers need to be restarted. So, I set the CI to not restart workers. Some tests may be missed, but otherwise we can't get through the test suite.

I'll open an issue as a follow up.

totally cool to disable things, basics are all that is needed here

@lithomas1
Copy link
Member Author

Yeah, I set it to always succeed in the testing phase since a lot of tests fail.

@jreback
Copy link
Contributor

jreback commented Dec 17, 2021

great as a follow up we should skip / xfail o ln pypy3

@jreback jreback merged commit 1fde76f into pandas-dev:master Dec 17, 2021
@lithomas1 lithomas1 deleted the pypy-support branch December 18, 2021 03:34
@jreback
Copy link
Contributor

jreback commented Jan 6, 2022

@lithomas1 hey if you can shoot me an email '[email protected]' have some info for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration PyPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants