-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Inconsistent conversion of missing column names #44878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0959372
Factor out existing occurrences
johnzangwill 276bdff
Don't change index.to_frame
johnzangwill 8a4879a
Merge branch 'pandas-dev:master' into fill-missing-names
johnzangwill 10bcdc4
Update v1.4.0.rst
johnzangwill e2a1247
Add docstring
johnzangwill aa6374a
Update multi.py
johnzangwill b2c4b92
Merge branch 'pandas-dev:master' into fill-missing-names
johnzangwill a6c2109
Improve whatsnew and test
johnzangwill 314b777
Merge branch 'pandas-dev:master' into fill-missing-names
johnzangwill c2d9668
Trigger CI
johnzangwill 94a86a0
Trigger CI
johnzangwill 4f569ad
Merge branch 'pandas-dev:master' into fill-missing-names
johnzangwill f311e49
Add types and improve docstring
johnzangwill 122eecd
Merge branch 'pandas-dev:master' into fill-missing-names
johnzangwill ac573b8
Update common.py
johnzangwill 76e864b
Update common.py
johnzangwill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -604,3 +604,10 @@ def is_builtin_func(arg): | |
otherwise return the arg | ||
""" | ||
return _builtin_table.get(arg, arg) | ||
|
||
|
||
def fill_missing_names(names): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you type in and out here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, and added version and more docstring. |
||
""" | ||
If a name is missing then replace it by level_n, where n is the count | ||
""" | ||
return [f"level_{i}" if name is None else name for i, name in enumerate(names)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add backticks around the
n
andlevel_n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done