BUG: fixed fillna('') on a Int64 column causes TypeError: <U3 cannot b… #44870
Conversation
…e converted to an IntegerDtype(pandas-dev#44289)
| ) | ||
| df.fillna("nan") | ||
|
|
||
| expected = df = DataFrame( |
There was a problem hiding this comment.
probably don't want to set both df and expected in this line?
There was a problem hiding this comment.
Interesting, I don't remember setting both df and expected like that - might have been a product of running pre-commit or something else? I can try to change this asap.
There was a problem hiding this comment.
can't imagine the pre-commit tooling doing this. most likely just a typo. happens to us all.
| if dtype == "Int64": | ||
| dtype = "int64" | ||
| elif dtype == "Float64": | ||
| dtype = "float64" |
There was a problem hiding this comment.
this is going to change behavior in an unwanted way. The issue is with 'fillna' with an Int64 dtype, not the existence of Int64 dtypes
There was a problem hiding this comment.
Agreed - as mentioned above in the description this contribution is for a final class project. Just trying to get a feel for contributing to open source software.
There was a problem hiding this comment.
Are you planning to follow-up on this? That's an important part of the contribution process!
jreback
added
Dtype Conversions
|
@aditzkabitz can you merge master and address comments |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in main, address the comments and we can reopen. |
…e converted to an IntegerDtype(#44289)
fillna('')on a Int64 column causesTypeError: <U3 cannot be converted to an IntegerDtype#44289this contribution is for a class project and need not be accepted but feedback is always appreciated