Skip to content

CLN: Split test_fields.py #44816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2021
Merged

CLN: Split test_fields.py #44816

merged 2 commits into from
Dec 8, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Dec 8, 2021
@mroeschke mroeschke added this to the 1.4 milestone Dec 8, 2021
@jreback
Copy link
Contributor

jreback commented Dec 8, 2021

@jbrockmendel https://github.com/pandas-dev/pandas/runs/4453493254?check_suite_focus=true maybe something changed in numpy?

@jbrockmendel
Copy link
Member

some of them look like changed exception messages which isn't too bad. not sure about the reductions

@jreback jreback merged commit 81b1598 into pandas-dev:master Dec 8, 2021
@jreback
Copy link
Contributor

jreback commented Dec 8, 2021

some of them look like changed exception messages which isn't too bad. not sure about the reductions

great thanks for having a look @jbrockmendel

@mroeschke mroeschke deleted the cln/test_fields branch December 8, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jreback @jbrockmendel