CI: use pytest-timeout to avoid windows timeouts #44814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 8, 2021
| @@ -13,6 +13,10 @@ | |||
| import pandas as pd | |||
| import pandas._testing as tm | |||
|
|
|||
| # Troubleshooting build failures on Windows that tentatively look like | |||
There was a problem hiding this comment.
My bet is this file as well.
The threading.Thread and http.server.HTTPServer can both lock I think.
I am attempting to convert this to a process we can terminate instead.
There was a problem hiding this comment.
OK. if you have a better solution on deck, should we close this?
There was a problem hiding this comment.
Probably best to keep it open to hopefully prove it was this file with a couple of CI passes.
Still trying to evaluate if a process is any better.
jreback
added
Testing
|
thanks, good to have in any event |
jbrockmendel
added a commit
that referenced
this pull request
Dec 12, 2021
This reverts commit 8f052de.
jreback
pushed a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from #44429, where I haven't seen any of the windows timeouts over quite a few runs.