Skip to content

Clarify regex interpretation in str.contains #44812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2021
Merged

Clarify regex interpretation in str.contains #44812

merged 2 commits into from
Dec 8, 2021

Conversation

nealmcb
Copy link
Contributor

@nealmcb nealmcb commented Dec 8, 2021 •
edited
Loading

Fix GH44811

@pep8speaks
Copy link

pep8speaks commented Dec 8, 2021 •
edited
Loading

Hello @nealmcb! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-12-08 01:49:44 UTC

@jreback jreback added Docs Indexing Related to indexing on series/frames, not to indexes themselves labels Dec 8, 2021
@jreback jreback added this to the 1.4 milestone Dec 8, 2021
@jreback jreback merged commit 2b756ad into pandas-dev:master Dec 8, 2021
@jreback
Copy link
Contributor

jreback commented Dec 8, 2021

thanks @nealmcb better error message are +1

@nealmcb nealmcb deleted the GH44811 branch December 8, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

ENH: note interpretation of pattern for str.contains as regex
3 participants
@nealmcb @pep8speaks @jreback