Skip to content

BUG/TST: ArrowStringArray skips/xfails #44795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2021
Merged

BUG/TST: ArrowStringArray skips/xfails #44795

merged 2 commits into from
Dec 7, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

This fixes ArrowStringArray.__eq__(some_list), but the Series method already works so i dont think it counts as user-facing.

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Strings String extension data type and string data labels Dec 7, 2021
@jreback jreback added this to the 1.4 milestone Dec 7, 2021
@jreback
Copy link
Contributor

jreback commented Dec 7, 2021

any user facing changes?

@jbrockmendel
Copy link
Member Author

not unless they're using ArrowStringArray directly; the Series method already works

@jreback jreback merged commit 8f8e3a8 into pandas-dev:master Dec 7, 2021
@jbrockmendel jbrockmendel deleted the bug-strings branch December 8, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Strings String extension data type and string data
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback