TYP: Create DeepChainMap from ChainMap.new_child in scope.py #44769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kashifkhan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-12-11 15:17:11 UTC |
jbrockmendel
reviewed
Dec 5, 2021
pandas/core/computation/scope.py
Outdated
| self.scope = self.scope.new_child( # type: ignore[assignment] | ||
| (global_dict or frame.f_globals).copy() | ||
| ) | ||
| self.scope = DeepChainMap(self.scope.new_child( (global_dict or frame.f_globals).copy())) |
There was a problem hiding this comment.
can you do this on two lines, so
foo = self.scope.whatever
self.scope = DeepChainMap(foo)
There was a problem hiding this comment.
sure, fixed in subsequent commits
|
@kashifkhan seems to be failing precommit; you can run this locally (and fix up) |
|
CI should be fixed if you merge master |
Sure Ill take care of this tomorrow !! |
|
thanks @kashifkhan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715
scope is created as a DeepChainMap but on lines 139, 145, 262 call to new_child was returning ChainMap. Created a new DeepChainMap from the resulting ChainMap.