Skip to content

CI/DOC: warning in docbuild #44756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2021
Merged

CI/DOC: warning in docbuild #44756

merged 2 commits into from
Dec 4, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added this to the 1.4 milestone Dec 4, 2021
@jreback jreback added the Docs label Dec 4, 2021
@jreback
Copy link
Contributor

jreback commented Dec 4, 2021

merge in green

@jbrockmendel
Copy link
Member Author 

----> 1 pd.read_csv(io.StringIO(data), true_values=["Yes"], false_values=["No"])

TypeError: initial_value must be str or None, not DataFrame

Maybe we need to freeze the old example so it doesnt get evaluated? i dont know how that works

@jreback
Copy link
Contributor

jreback commented Dec 4, 2021

use a ioython block and paste the example in

@phofl
Copy link
Member

phofl commented Dec 4, 2021

Thx for fixing

@jbrockmendel
Copy link
Member Author

@jreback green but im really not confident when it comes to code-block stuff

jreback
jreback reviewed Dec 4, 2021
View reviewed changes
doc/source/whatsnew/v0.10.0.rst
@@ -181,6 +181,7 @@ labeled the aggregated group with the end of the interval: the next day).
``X0``, ``X1``, ...) can be reproduced by specifying ``prefix='X'``:

.. ipython:: python
:okwarning:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob dont' need this now, but nbd.

@jreback jreback merged commit daac93c into pandas-dev:master Dec 4, 2021
@jreback
Copy link
Contributor

jreback commented Dec 4, 2021

don't need the okwarning but ok

@jbrockmendel jbrockmendel deleted the ci-docbuild branch December 4, 2021 23:41
@rhshadrach rhshadrach mentioned this pull request Dec 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @phofl