Skip to content

TST: stricten xfails #44741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pandas/tests/io/parser/common/test_chunksize.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ def test_chunk_begins_with_newline_whitespace(all_parsers):


@pytest.mark.slow
@pytest.mark.xfail(reason="GH38630, sometimes gives ResourceWarning", strict=False)
def test_chunks_have_consistent_numerical_type(all_parsers):
parser = all_parsers
integers = [str(i) for i in range(499999)]
Expand Down
10 changes: 1 addition & 9 deletions pandas/tests/plotting/test_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@

import pandas._config.config as cf

from pandas.compat import (
is_platform_windows,
np_datetime64_compat,
)
from pandas.compat import np_datetime64_compat
import pandas.util._test_decorators as td

from pandas import (
Expand Down Expand Up @@ -92,11 +89,6 @@ def test_registering_no_warning(self):
ax.plot(s.index, s.values)
plt.close()

@pytest.mark.xfail(
is_platform_windows(),
reason="Getting two warnings intermittently, see GH#37746",
strict=False,
)
def test_pandas_plots_register(self):
plt = pytest.importorskip("matplotlib.pyplot")
s = Series(range(12), index=date_range("2017", periods=12))
Expand Down
6 changes: 0 additions & 6 deletions pandas/tests/plotting/test_groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import numpy as np
import pytest

from pandas.compat import is_platform_windows
import pandas.util._test_decorators as td

from pandas import (
Expand All @@ -20,11 +19,6 @@

@td.skip_if_no_mpl
class TestDataFrameGroupByPlots(TestPlotBase):
@pytest.mark.xfail(
is_platform_windows(),
reason="Looks like LinePlot._is_ts_plot is wrong",
strict=False,
)
def test_series_groupby_plotting_nominally_works(self):
n = 10
weight = Series(np.random.normal(166, 20, size=n))
Expand Down
2 changes: 0 additions & 2 deletions pandas/tests/tseries/offsets/test_offsets_properties.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
assume,
given,
)
from hypothesis.errors import Flaky
import pytest
import pytz

Expand Down Expand Up @@ -45,7 +44,6 @@ def test_on_offset_implementations(dt, offset):
assert offset.is_on_offset(dt) == (compare == dt)


@pytest.mark.xfail(strict=False, raises=Flaky, reason="unreliable test timings")
@given(YQM_OFFSET)
def test_shift_across_dst(offset):
# GH#18319 check that 1) timezone is correctly normalized and
Expand Down