Skip to content

TST: dont skip dt64tz rolling tests #44730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

TST: dont skip dt64tz rolling tests #44730

merged 1 commit into from
Dec 3, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

cc @mroeschke removing the 'category' skip doesn't break anything but i have no idea if that means the test is right.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Dec 2, 2021
@mroeschke mroeschke added this to the 1.4 milestone Dec 2, 2021
mroeschke
mroeschke approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring green.

@jreback jreback merged commit ef50cd6 into pandas-dev:master Dec 3, 2021
@jbrockmendel jbrockmendel deleted the tst-skip-to-xfail branch December 3, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @jreback