TST: remove non-strict xfails #44728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW these tests shouldn't be running in the CI currently since we switched to a moto service. This might be only applicable for local runs? |
mroeschke
approved these changes
Dec 3, 2021
|
if they're not being run on the CI then aren't they kind of pointless? |
|
These tests should be useful for those who run the test suite locally in which case these tests are still useful. In theory, if/once CI platforms allows moto service images for non-Linux OSs these tests should be run-able. |
|
Makes sense, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If/when this gets to green, I'll want to re-run it a few times to make sure it stays that way.