Skip to content

CI: Try to not auto-cancel on master #44682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 1, 2021
Merged

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Nov 30, 2021

Seems to work. Let's try this again.

@lithomas1 lithomas1 added the CI Continuous Integration label Nov 30, 2021
@lithomas1 lithomas1 added this to the 1.4 milestone Nov 30, 2021
@lithomas1 lithomas1 marked this pull request as ready for review November 30, 2021 04:28
@jreback
Copy link
Contributor

jreback commented Nov 30, 2021

@lithomas1 works? or we should just merge and see?

@lithomas1
Copy link
Member Author

Yup, it seems to not cancel on a fake 1.3.x branch that I created locally and seems to cancel correctly on the pull request here properly. I'll still monitor to make sure it's working properly, though.

@lithomas1 lithomas1 requested a review from jreback December 1, 2021 03:57
@jreback jreback merged commit db10480 into pandas-dev:master Dec 1, 2021
@jreback
Copy link
Contributor

jreback commented Dec 1, 2021

thanks @lithomas1

@lithomas1 lithomas1 deleted the 1.3.x branch December 1, 2021 23:43
@jbrockmendel
Copy link
Member

I just got 14 emails about a single CI run being cancelled. This is the most recent CI-centric PR merged AFAICT. Any chance there's a connection?

@jorisvandenbossche
Copy link
Member

I also just noticed this. Github actions is complaining about a line that was added in this PR (see eg https://github.com/pandas-dev/pandas/actions/runs/1535966470/workflow), but the strange thing is that this only started failing more recently on master (so after this PR was merged, there have been several other commits where github actions still ran)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: disable auto-cancel for master branch
4 participants