-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Try to not auto-cancel on master #44682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lithomas1 works? or we should just merge and see? |
Yup, it seems to not cancel on a fake 1.3.x branch that I created locally and seems to cancel correctly on the pull request here properly. I'll still monitor to make sure it's working properly, though. |
thanks @lithomas1 |
I just got 14 emails about a single CI run being cancelled. This is the most recent CI-centric PR merged AFAICT. Any chance there's a connection? |
I also just noticed this. Github actions is complaining about a line that was added in this PR (see eg https://github.com/pandas-dev/pandas/actions/runs/1535966470/workflow), but the strange thing is that this only started failing more recently on master (so after this PR was merged, there have been several other commits where github actions still ran) |
Seems to work. Let's try this again.