Skip to content

Type read_fwf #44678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2021
Merged

Type read_fwf #44678

merged 2 commits into from
Dec 1, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 29, 2021

  • Ensure all linting tests pass, see here for how to run them

@phofl phofl added IO Fixed Width read_fwf Typing type annotations, mypy/pyright type checking labels Nov 29, 2021
twoertwein
twoertwein reviewed Dec 1, 2021
View reviewed changes
@phofl
Copy link
Member Author

phofl commented Dec 1, 2021

Thanks for the rewview

twoertwein
twoertwein approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@jreback jreback added this to the 1.4 milestone Dec 1, 2021
@jreback jreback merged commit 9f5e609 into pandas-dev:master Dec 1, 2021
@phofl phofl deleted the typ_read_fwf branch December 1, 2021 23:11
@twoertwein twoertwein mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
IO Fixed Width read_fwf Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @twoertwein @jreback