-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: fix .loc.__setitem__ not raising when using too many indexers #44656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ca37c9c
BUG: fix .loc.__setitem__ not raising when using too many indexers
DriesSchaumont c34acb2
Merge remote-tracking branch 'upstream/master' into fix-13831
DriesSchaumont d886470
Updates solution and added extra test
DriesSchaumont 5bae428
Add whatsnew
DriesSchaumont 06eb7e4
Updates for review.
DriesSchaumont 453e3ba
Merge remote-tracking branch 'upstream/master' into fix-13831
DriesSchaumont 8c53bba
Merge remote-tracking branch 'upstream/master' into fix-13831
DriesSchaumont 8e44463
Add test for list indexer.
DriesSchaumont e5a768f
Merge remote-tracking branch 'upstream/master' into fix-13831
DriesSchaumont 7880015
Add indexer_li fixture.
DriesSchaumont f83cfc8
Merge remote-tracking branch 'upstream/master' into fix-13831
DriesSchaumont b5c664d
Add comment to test.
DriesSchaumont f7bc4a0
Move docs to 1.5
DriesSchaumont 8daced5
Merge remote-tracking branch 'upstream/main' into fix-13831
DriesSchaumont 3ebf788
Merge remote-tracking branch 'upstream/main' into fix-13831
DriesSchaumont File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah let's move this to 1.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I moved whatsnew