Skip to content

CI/TST: Change id to is for flaky tests #44650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2021
Merged

CI/TST: Change id to is for flaky tests #44650

merged 3 commits into from
Nov 28, 2021

Conversation

mroeschke
Copy link
Member

I think this should be in the spirit of the intended test to make things less flaky hopefully cc @jbrockmendel

@mroeschke mroeschke changed the title CI/TST: Change id to np.shares_memory for flaky tests CI/TST: Change id to is for flaky tests Nov 28, 2021
@mroeschke mroeschke added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Nov 28, 2021
@mroeschke mroeschke added this to the 1.4 milestone Nov 28, 2021
@jreback jreback merged commit a7b536c into pandas-dev:master Nov 28, 2021
@mroeschke mroeschke deleted the ci/flaky/id_check branch November 28, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

CI: Flakey Arm Tests
3 participants
@mroeschke @jbrockmendel @jreback