Skip to content

CI/TST: Add network tests to CI #44648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2021
Merged

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Nov 28, 2021

No network tests were running on the CI, so adding these tests to PY38 and PY39 Linux, MacOS and Window builds

@lithomas1
Copy link
Member

We might want to run these on the database builds as well and maybe a slow build. LGTM otherwise.

@mroeschke mroeschke added this to the 1.4 milestone Nov 28, 2021
@mroeschke mroeschke added CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues labels Nov 28, 2021
@mroeschke
Copy link
Member Author

We might want to run these on the database builds as well and maybe a slow build

Hmm wouldn't that just be essentially duplicating the same tests in multiple PY38 or PY39 environments (AFAICT these tests don't depend on optional dependencies since it used urllib to make the network call)?

@jreback
Copy link
Contributor

jreback commented Nov 29, 2021

We might want to run these on the database builds as well and maybe a slow build

Hmm wouldn't that just be essentially duplicating the same tests in multiple PY38 or PY39 environments (AFAICT these tests don't depend on optional dependencies since it used urllib to make the network call)?

yeah just a fast & slow build are fine

@jreback
Copy link
Contributor

jreback commented Nov 29, 2021

can you only enable this on a few builds? the linux ones are prob enough (e.g. 1 fast and 1 slow)

@mroeschke
Copy link
Member Author

can you only enable this on a few builds? the linux ones are prob enough (e.g. 1 fast and 1 slow)

These are enabled on:

Linux PY38
Linux PY39
MacOS PY38
Windows PY38
Windows PY39

which is good coverage IMO. Running on a slow build I don't think is worth it because it's equivalent to running on Linux PY38 twice.

@jreback jreback merged commit f42fff8 into pandas-dev:master Nov 29, 2021
@mroeschke mroeschke deleted the ci/network_tests branch November 29, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: network tests
3 participants