-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI/TST: Add network tests to CI #44648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We might want to run these on the database builds as well and maybe a slow build. LGTM otherwise. |
This reverts commit 649b69f.
Hmm wouldn't that just be essentially duplicating the same tests in multiple PY38 or PY39 environments (AFAICT these tests don't depend on optional dependencies since it used urllib to make the network call)? |
yeah just a fast & slow build are fine |
can you only enable this on a few builds? the linux ones are prob enough (e.g. 1 fast and 1 slow) |
These are enabled on: Linux PY38 which is good coverage IMO. Running on a slow build I don't think is worth it because it's equivalent to running on Linux PY38 twice. |
No network tests were running on the CI, so adding these tests to PY38 and PY39 Linux, MacOS and Window builds