-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: mangle_dup_cols in read_csv replacing existing cols when conflict with target col #44641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gfyoung if any comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The modified expected results for the tests will take a little getting used to, but they of course make total sense.
Thx |
I think its worth making this a sub-section in the whatsnew docs to highlite it. |
Added the sub section |
@jreback greenish |
thanks @phofl |
Are you sure? previous commit was green, only merged master and modified whatsnew afterwards. |
not sure at all - if it's not a problem on master then ignore |
Have seen similar things in the past like https://github.com/pandas-dev/pandas/runs/4331169003, hence assumed this would be unrelated. Lets see if it passes on master |
This ensures that already existing column names are kept. The index of the duplicated col is one higher in this case