BUG: read_csv not converting original col with keep_date_col true #44633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
phofl
commented
Nov 26, 2021
phofl
commented
- closes BUG: in read_csv, keep_date_cols doesn't result in correct dtype #13378
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
� Conflicts: � doc/source/whatsnew/v1.4.0.rst
jreback
reviewed
Nov 26, 2021
| @@ -1148,6 +1148,10 @@ def _isindex(colspec): | |||
| ) | |||
|
|
|||
| new_data[new_name] = col | |||
|
|
|||
| if len(colspec) == 1: | |||
There was a problem hiding this comment.
this seems like very special casey here
There was a problem hiding this comment.
It is, yes. We can only keep the original column formatted as date, if it represents the whole date. In cases where two columns combined represent a date we can only keep the original format
There was a problem hiding this comment.
ok worth a comment about this then for future readers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.