Skip to content

REF: expressions bug in Block.where #44631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

REF: expressions bug in Block.where #44631

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b2cc9f
API: don't downcast ints in Block.where
jbrockmendel Nov 26, 2021
6c3b5ab
Merge branch 'master' into ref-where-1block
jbrockmendel Nov 30, 2021
7695edb
restore casting, so just the expressions left
jbrockmendel Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pandas/core/internals/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,6 +1215,19 @@ def where(self, other, cond) -> list[Block]:
else:
# By the time we get here, we should have all Series/Index
# args extracted to ndarray
if (
is_list_like(other)
and not isinstance(other, np.ndarray)
and len(other) == self.shape[-1]
):
# If we don't do this broadcasting here, then expressions.where
# will broadcast a 1D other to be row-like instead of
# column-like.
other = np.array(other).reshape(values.shape)
# If lengths don't match (or len(other)==1), we will raise
# inside expressions.where, see test_series_where

# Note: expressions.where may upcast.
result = expressions.where(~icond, values, other)

if self._can_hold_na or self.ndim == 1:
Expand Down