Skip to content

WIP/CI: Debug segfault in ci/code_checks.sh docstrings #44630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mroeschke
Copy link
Member

xref #44590

@mroeschke mroeschke marked this pull request as draft November 26, 2021 23:59
@johnzangwill
Copy link
Contributor

@phofl, @mroeschke: This may be nothing to do with it, but the last log output before the #44590 segfault was from errors/__init__.py.

I ran (on Windows):

python scripts/validate_docstrings.py pandas.errors.DtypeWarning

repeatedly in multiple processes, and it quickly crashed with contention over test.csv.

@mroeschke
Copy link
Member Author

repeatedly in multiple processes, and it quickly crashed with contention over test.csv.

It might be good just to use io.StringIO here. I don't think it's great in general that the doctests are writing to a file.

@mroeschke
Copy link
Member Author

Not yielding much as of late. Closing

@mroeschke mroeschke closed this Dec 3, 2021
@mroeschke mroeschke deleted the ci/debug/docstrings/segfault branch December 3, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants