Skip to content

Fix issue #36271 - pd.read_json() fails for strings that look similar to fsspec_url #44619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 27, 2021

Conversation

mntss
Copy link
Contributor

@mntss mntss commented Nov 25, 2021

Copy link

@steve-mavens steve-mavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this corresponds to what I said in the issue thread.

My information might be out of date, but arguably the regex should be compiled once at module level, so as to avoid the (slight) risk that in a program using lots of regexes, it gets evicted from the cache and therefore has to be (slightly) slowly recompiled each time it's used.

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always add tests

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection to the change

  • can u add a whatsnew note 1.4
    i/o bug fix section
  • can u add a test that replicates the OP - using read_json

@jreback jreback added IO JSON read_json, to_json, json_normalize IO Data IO issues that don't fit into a more specific label labels Nov 25, 2021
@jreback jreback added this to the 1.4 milestone Nov 26, 2021
@jreback
Copy link
Contributor

jreback commented Dec 23, 2021

@mntss can you address comments and merge master

@jreback jreback closed this Dec 27, 2021
@jreback jreback reopened this Dec 27, 2021
@jreback jreback merged commit eeff2b0 into pandas-dev:master Dec 27, 2021
@jreback
Copy link
Contributor

jreback commented Dec 27, 2021

thanks @mntss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: since pandas==1.1.0 pd.read_json() fails for strings that look similar to fsspec_url
4 participants