-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix issue #36271 - pd.read_json() fails for strings that look similar to fsspec_url #44619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mntss
commented
Nov 25, 2021
•
edited
Loading
edited
- closes BUG: since pandas==1.1.0 pd.read_json() fails for strings that look similar to fsspec_url #36271
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this corresponds to what I said in the issue thread.
My information might be out of date, but arguably the regex should be compiled once at module level, so as to avoid the (slight) risk that in a program using lots of regexes, it gets evicted from the cache and therefore has to be (slightly) slowly recompiled each time it's used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no objection to the change
- can u add a whatsnew note 1.4
i/o bug fix section - can u add a test that replicates the OP - using read_json
@mntss can you address comments and merge master |
thanks @mntss |