Skip to content

TST: Use subprocess.Popen as context managers #44611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

TST: Use subprocess.Popen as context managers #44611

merged 1 commit into from
Nov 25, 2021

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Nov 24, 2021 •
edited
Loading

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

Might help address the elusive ResourceWarnings in the CI
https://github.com/pandas-dev/pandas/runs/4317219787?check_suite_focus=true

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 25, 2021
@mroeschke mroeschke added this to the 1.4 milestone Nov 25, 2021
@jreback jreback merged commit 81fa367 into pandas-dev:master Nov 25, 2021
@jreback
Copy link
Contributor

jreback commented Nov 25, 2021

looks fine. you might want to propagate this upstream to the clipboard library itself as we vendor this.

@mroeschke mroeschke deleted the tests/popen_context branch November 25, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback