PERF: Improve performance in read_csv with numeric index col #44610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
IO CSV
|
the benchmark runner failed, not really sure why |
|
I think I have used the wrong base class, changed it |
|
greenish now |
jreback
requested changes
Nov 25, 2021
| @@ -518,6 +518,7 @@ Performance improvements | |||
| - Performance improvement in :meth:`Series.to_frame` (:issue:`43558`) | |||
| - Performance improvement in :meth:`Series.mad` (:issue:`43010`) | |||
| - Performance improvement in :func:`merge` (:issue:`43332`) | |||
| - Performance improvement in :func:`read_csv` when ``index_col`` was set with a numeric column (:issue:`44158`) | |||
There was a problem hiding this comment.
i think this is a regression compared to 1.3.x. would be ok backporting.
There was a problem hiding this comment.
This is equally slow on 1.2.5 and 1.3.4, so don't think we should backport
jreback
approved these changes
Nov 25, 2021
|
thanks @phofl very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isin was calling the np.in1d and was checking against a bunch of strings causing the performance issues