Skip to content

REF: dont call maybe_promote with EA dtype #44606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2021
Merged

REF: dont call maybe_promote with EA dtype #44606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c0dfdf
REF: dont call maybe_promote with EA dtype
jbrockmendel Nov 24, 2021
90786f4
Merge branch 'master' into ref-maybe_promote-only-np
jbrockmendel Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas/core/reshape/reshape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,24 +245,24 @@ def get_new_values(self, values, fill_value=None):
new_mask = np.ones(result_shape, dtype=bool)
return new_values, new_mask

dtype = values.dtype

# if our mask is all True, then we can use our existing dtype
if mask_all:
dtype = values.dtype
new_values = np.empty(result_shape, dtype=dtype)
name = np.dtype(dtype).name
else:
dtype, fill_value = maybe_promote(values.dtype, fill_value)
if isinstance(dtype, ExtensionDtype):
# GH#41875
cls = dtype.construct_array_type()
new_values = cls._empty(result_shape, dtype=dtype)
new_values[:] = fill_value
name = dtype.name
else:
dtype, fill_value = maybe_promote(dtype, fill_value)
new_values = np.empty(result_shape, dtype=dtype)
new_values.fill(fill_value)
name = np.dtype(dtype).name

name = dtype.name
new_mask = np.zeros(result_shape, dtype=bool)

# we need to convert to a basic dtype
Expand Down